search

cgobat / asymmetric_uncertainty

A package for handling numeric quantities with asymmetric uncertainties.
https://github.com/cgobat/asymmetric_uncertainty/wiki
GNU General Public License v3.0
18 stars 4 forks source link

Bug fix: dependency installation order issue #7

Closed cgobat closed 1 year ago

cgobat commented 1 year ago

The setup/installation routine (invoked e.g. by pip install) previously attempted to import from the main code file before installing the package dependencies. This meant that if numpy and/or matplotlib were not already installed in the working environment, an error would occur when core.py tried to import them.

This PR resolves the problem by removing the from asymmetric_uncertainty import ... statement in setup.py, and instead just using literals to declare the metadata arguments to setup().

sevenstarknight commented 1 year ago

The setup/installation routine (invoked e.g. by pip install) previously attempted to import from the main code file before installing the package dependencies. This meant that if numpy and/or matplotlib were not already installed in the working environment, an error would occur when core.py tried to import them.

This PR resolves the problem by removing the from asymmetric_uncertainty import ... statement in setup.py, and instead just using literals to declare the metadata arguments to setup().

When will this MR be pushed? I'd like to make sure it works with my current version of code. Thank you again for your assistance, please let me know if I can be of help.

cgobat commented 1 year ago

Let me know if you run into any further issues. Cheers!