Fix broken test and pass creds through env

cgoldberg / sauceclient

Python client library for Sauce Labs API

Apache License 2.0

11 stars 25 forks source link

Fix broken test and pass creds through env #1

Closed lorin closed 9 years ago

lorin commented 11 years ago

Removes the check for preferred_version, which isn't present in Sauce anymore.

Allow user to specify SAUCE_USERNAME, SAUCE_ACCESS_KEY, TEST_JOB_ID by environment variable.

cgoldberg commented 11 years ago

this looks good. can you also update the docs in your branch for running tests: /doc/development.rst specifically, the "Running the Unit Tests" section.

once that is updated, I can merge your changes. thanks!

-Corey

sontek commented 9 years ago

@cgoldberg He made the changes you requested, anything holding this back?

cgoldberg commented 9 years ago

@sontek I just merged the PR. thanks for the reminder... I totally forgot about it :)

sontek commented 9 years ago

@cgoldberg Thanks! I'll have a few PRs for you in a few minutes :)