cgoldberg / sauceclient

Python client library for Sauce Labs API
Apache License 2.0
11 stars 25 forks source link

New SauceLabs EU Data Center #21

Open xray5483 opened 5 years ago

xray5483 commented 5 years ago

Hi there, A few days back SauceLabs have inaugurated their new EU Data Centre in Frankfurt. In order to switch to it there are some changes that need to be performed within the sauceclient.py file like:

self.apibase = apibase or 'eu-central-1.saucelabs.com'

and

def get_job_asset_url(self, job_id, filename): """Get details about the static assets collected for a specific job.""" return 'https://eu-central-1.saucelabs.com/rest/v1/{}/jobs/{}/assets/{}'.format( self.client.sauce_username, job_id, filename)

I didn't have push access to propose the update as part of a new branch / pull request thus raised it as an issue!

Please have a look at this page for the new details provided by SauceLabs here

Regards, Ray

cgoldberg commented 5 years ago

Thanks for notifying me. I can make these changes if you'd like. However, you could also use this as an opportunity to learn open source development. It's easy to participate!

I didn't have push access to propose the update as part of a new branch / pull request

You don't need push access to my repo to submit a Pull Request.

Follow these steps:

Once you submit the Pull Request, I will either accept the Pull Request as-is, or I will request that you make changes to your branch. Once satisfied, I will merge the Pull Request (adding the commits from your branch to my repo's master branch).

for more details, see: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

Thanks!

cgoldberg commented 5 years ago

bump

LasseHall commented 4 years ago

@cgoldberg my understanding is that the current implementation of apibase on master is enough for the use of EU DC. My only problem is that PyPI doesn't have a release with the relevant commit so I have to use an awkward -e git+https://github.com/cgoldberg/sauceclient.git#egg=sauceclient in requirements of my python project.

Can you create a release in PyPI?

dshuga commented 3 years ago

Can you create a release in PyPI?

Bump