search

cgoldberg / xvfbwrapper

Manage headless displays with Xvfb (X virtual framebuffer)
Other
295 stars 52 forks source link

API change breaking OpenStack Horizon integration tests #12

Closed vstinner closed 7 years ago

vstinner commented 8 years ago

Hi,

Good news: your project is used in integration tests of OpenStack Horizon!

Bad news: you broke your API without any warning, nor bumping the major version :-/ (no semantic version? ;-))

I'm talking about the change https://github.com/cgoldberg/xvfbwrapper/commit/9a8c0e80f6a932d5448d1b97d5a9c316a7a7c8e3 which renamed xvfb_cmd to extra_xvfb_args.

Horizon bug report: https://bugs.launchpad.net/horizon/+bug/1540495

One fix (which doesn't look to work?): https://review.openstack.org/274812

My fix: https://review.openstack.org/275401

vstinner commented 8 years ago

By the way, since your project is used, please try at least to tag versions in git :-) Maybe also write a changelog? And bump major version on API change? http://semver.org/

Your project is 4 years old, it's maybe time to start to think about stabilizing the API and reaching a version 1.0? ;-)

(Just random ideas, then it's your project, don't worry ;-))

tsufiev commented 8 years ago

Hello, @cgoldberg! @haypo is right, your project is very important to automated testing of Horizon on gate :). Although we've already worked around recent API changes in https://review.openstack.org/#/c/275401/ some understanding which API is external and which is internal would help us to avoid such issues in future.

Besides that, what do you think of implementing http://blog.jeffterrace.com/2012/07/xvfb-memory-leak-workaround.html directly inside xvfbwrapper?

vstinner commented 7 years ago

The issue has been worked around in Horizon, so it's fine. Let's close this old issue.