search

cgoldberg / xvfbwrapper

Manage headless displays with Xvfb (X virtual framebuffer)
Other
295 stars 52 forks source link

xvfbwrapper.py:57 cygwin/win32 compatibility #19

Closed mklump closed 7 years ago

mklump commented 8 years ago

I recommend on line 57 setting the keyword argument close_fds=False as the fourth positional argument in the function call to self.proc = subprocess.Popen() checking and/or if: block handling to maintain correct/better compatibility to the win32 OS with cygwin\bin version of Xvfb that is installed.

cgoldberg commented 8 years ago

pull requests are welcome. I don't have a Windows machine to test on.