search

cgonz0 / bwa-u4-feature-request

0 stars 0 forks source link

Feature Request Review #1

Open mp1pro opened 6 years ago

mp1pro commented 6 years ago

Adding the ability to trigger the search function by pressing enter button will improve the interface and the users experience. Showing the album art cover will also improves the efficiency of the app.

The technical design you have layed out for the enter key is correct, following your instructions, I would have 

  handleKeyPress(event) {
    if(event.keyCode === 13) {
      this.search();
    }
}

and <input onKeyPress={this.handleKeyPress}/>

The technical design for grabbing the art cover is also accurate and is the best approach. Great job on researching what the spotify API has to offer and how to access it. Both features sounds on point.

cgonz0 commented 6 years ago

@mp1pro awesome, thanks for the review!