Closed JanDiederich closed 5 months ago
Hi! Thanks for the code! I should be able to look this over soon.
Merged - much appreciated! I only modified this with changed proposed by fmt
and clippy
. I have since updated the github actions config so that these will automatically run on future pull-requests.
Big thanks for including my Pull-Request.
Hi, I had to make some changes to make the library work for me, please let me explain why I did what:
DeviceInfoResponse
: The Twinkly Squares 2nd Generation I use this with, miss a field (flash_size
) and have a field (pwr
), which I had to make Optional (flash_size
) and add as Optional (pwr
).PartialEq
,Eq
derivatives, and PartialOrd implementation. The last one to make it easier to compare lists, which have the same order. I need to figure out if a device is a actually new -- or just a new IP-Address, longer uptime, etc.All in all I'm very thankful for your work. Big thanks.
If you see problems in my Pull-Request, please explain, I will fix them.