Faster device search, better data handling, Get/Set Brightness

JanDiederich commented 3 months ago

Hi, your issue: #33, is something I have worked on.

Because I just made some optimizations, so that devices which were already found, and are just in use, aren't reloaded when new devices are searched. If a device which has already been loaded, and is just showing an animation, is reauthenticated, and data fetched from it, it will stutter horribly, ruining any animation. It will stutter a little bit for already responding to the search request, but not by that much if the whole Device-Loading and Authentication part is skipped. All in all, it speeds up the device discovery recognizable, thanks also to now reusing the authentication-token from the device discovery.
I also made it easier to reauthenticate.
Added some derivatives to easier manipulate some data structures.
Reading the authentication_token_expires_in field. While it's currently always the same, this may change in the future.
Replaced the empty Result of set_rt_frame_socket with the actually written bytes, for better error detection.
Setting and Getting the Brightness, which is essential, because if you have a big block of bright Twinkly lights, and the room hasn't walls and ceiling made out of glass, it's far too bright. The brightness-level must be reduced, individually for the room and daytime.
Edit: I added a trait to check the result code, where Twinkly devices communicate not only if they received the message, but also if it was correct. Like "I could receive the message (HTTP Status Code 200), but the content was wrong (JSON Code Xyz)".

Normally I would've collected my changes longer, but since reading #33, I wanted to show you the results of my work now, and hope you consider them when working on #33.

@cgorski Thanks for the library, if you need any changes, please let me know.

cgorski commented 3 months ago

thank you! I'm away on holiday for the next few days, but I'll look at this sometime next week.

cgorski commented 2 months ago

Thanks for this commit, your contribution is much appreciated!

cgorski commented 2 months ago

I'll push this out in a new release shortly

JanDiederich commented 3 weeks ago

I'll push this out in a new release shortly

@cgorski Well, that was over a month ago. Did you forget the release or do you want to change something else first?

cgorski commented 2 weeks ago

@JanDiederich 0.6.0 just published, thanks!

cgorski / glow-control

Faster device search, better data handling, Get/Set Brightness #34