search

cgq-qgc / pyhelp

A Python library for the assessment of spatially distributed groundwater recharge and hydrological components with HELP
MIT License
17 stars 5 forks source link

Define SUBROUTINE and FUNCTION argument typespec explicitely in HELP #24

Open jnsebgosselin opened 5 years ago

jnsebgosselin commented 5 years ago

As mentionned in https://github.com/jnsebgosselin/pyhelp/pull/22#issuecomment-434715877, arguments of each SUBROUTINE or FUNCTION should be explicitly defined. This is to avoid warning or the type vars2fortran: No typespec for argument "nt". Block: leap when compiling with f2py.

For example, the SUBROUTINE READIN does not produce such a warnings.

C      ************************* READIN *************************
C
C  SUBROUTINE READIN READS ET AND SOIL DESIGN DATA, AND WEATHER HEADERS
C
      SUBROUTINE READIN (fpath_precip, fpath_tasavg, fpath_solrad,
     1 fpath_evapo, fpath_soil)

      CHARACTER(len=260), INTENT(IN) :: fpath_precip
      CHARACTER(len=260), INTENT(IN) :: fpath_tasavg
      CHARACTER(len=260), INTENT(IN) :: fpath_solrad
      CHARACTER(len=260), INTENT(IN) :: fpath_evapo
      CHARACTER(len=260), INTENT(IN) :: fpath_soil

So I think this can be safely ignored for the moment.