search

cgrand / xforms

Extra transducers and reducing fns for Clojure(script)
575 stars 32 forks source link

CLJS compilation warning #49

Closed den1k closed 2 years ago

den1k commented 2 years ago

Version: 0.19.3

Assuming this will break in cljs

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: net/cgrand/xforms.cljc:134:20
--------------------------------------------------------------------------------
 131 | ;; Workaround clojure.core/satisfies? being slow in Clojure
 132 | ;; see https://ask.clojure.org/index.php/3304/make-satisfies-as-fast-as-a-protocol-method-call
 133 | #?(:cljs
 134 |    (def satisfies? core/satisfies?)
--------------------------^-----------------------------------------------------
 Can't take value of macro cljs.core/satisfies?
imrekoszo commented 2 years ago

That's a good catch, thank you. Do you have a minimal repro for tgis by any chance? I don't have cljs set up and would like to make sure I don't make it worse.

imrekoszo commented 2 years ago

Fixed in https://github.com/cgrand/xforms/releases/tag/v0.19.4