search

cgrand / xforms

Extra transducers and reducing fns for Clojure(script)
575 stars 32 forks source link

questionable line in `trial` #8

Closed rebcabin closed 7 years ago

rebcabin commented 7 years ago

I noticed the following line in the tests

    (trial xform n (repeatedly #(#?(:clj Object. :clj js/Object.))) coll))

and thought the second term might be a typo. Perhaps the line should be

    (trial xform n (repeatedly #(#?(:clj Object. :cljs js/Object.))) coll))

I'd have tried it but I don't yet know how to run ClojureScript.

cgrand commented 7 years ago

Thanks, good catch.

Le sam. 7 janv. 2017 à 22:51, rebcabin notifications@github.com a écrit :

I noticed the following line in the tests

(trial xform n (repeatedly #(#?(:clj Object. :clj js/Object.))) coll))

and thought the second term might be a typo. Perhaps the line should be

(trial xform n (repeatedly #(#?(:clj Object. :cljs js/Object.))) coll))

I'd have tried it but I don't yet know how to run ClojureScript.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cgrand/xforms/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC3sSu3KjTSv9nocVD70lmUzlUgFyKVks5rQAjXgaJpZM4LdiW9 .