search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
230 stars 62 forks source link

Added support for Twonky and Rhapsody #1

Closed munsellj closed 12 years ago

munsellj commented 12 years ago

Hi,

First of all, I love this extension! I added support for scrobbling from my.twonky.com(Music -> My Library) and Rhapsody, a couple of websites I listen to music on a lot. I think I got everything required and tried to follow all the same styles/conventions, but feel free to let me know if there are any changes you'd like me to make. I tested locally and both sites are now scrobbling :-)

The only thing I wasn't sure of was your versioning scheme so I didn't update the version number. Would love it if you would pull in my changes after review and post the update to the Chrome Web Store!

Thanks, Jonathon

cgravolet commented 12 years ago

Thanks Jonathon!

I'm going to test out the changes for a bit and then I'll package it up and update it on the chrome web store later this weekend hopefully.

Charles

cgravolet commented 12 years ago

Minor changes:

I added elapsed time to the Rhapsody scraper method since it's available, the scrobbling is much more reliable when elapsed time is available.

Also, there was a bug with Safari scrobbling of Rhapsody since Safari will run the injection scripts on all frames. Rhapsody has about 4-5 iframes on the page, plus it opens a new frame everytime you start a new station so I needed to add some code that makes sure it's only running scroblr on the main window/frame.

Charles

munsellj commented 12 years ago

Awesome, thanks Charles! Sorry, I got a bit excited and forgot to test in Safari(don't usually use Safari extensions). Will remember next time :-)