search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

Add Firefox support #102

Closed cnnrhill closed 8 years ago

cnnrhill commented 8 years ago

Hi, this adds Firefox support to scroblr (#30). grunt build and grunt release create a .xpi file which can be installed in Firefox. Tested on Firefox 38+.

cgravolet commented 8 years ago

This is cool, thanks for contributing. Will merge it later this week after a quick fix to another plugin is released.

cincodenada commented 8 years ago

Wow, excellent! I have long hoped this extension would get a Firefox version, was setting up a new computer which sent me searching again. I happened to look at the GitHub for my trusty Chrome extension, and noticed the merge commit. Cloned, built, and now scrobbling from Pandora flawlessly. Thanks for the good work, @cnnrhill! You're a saint. Y'all feel free to ping me if you need help testing things, I'll let you know if I notice any issues.

bonyboy commented 8 years ago

@cincodenada How did you build the app to install as an add-on for Firefox?

cincodenada commented 8 years ago

@bonyboy I'm pretty sure I just followed the guide on the wiki, I don't recall having to do anything funny. Until it's official and such, you'll have to twiddle with your Firefox settings to allow unsigned extensions though.

bonyboy commented 8 years ago

Oh I see. Thanks for showing that to me!

hans-juergen commented 8 years ago

OK, so maybe this should be mentioned on the homepage as well, i.e. scroblr also supports Firefox now? ;-) And probably this open issue can be closed then: https://github.com/cgravolet/scroblr/issues/30

Just to make sure, is this using the new WebExtensions API in Firefox already? As far as I know, adding Chrome-like extensions to Firefox is possible in brand-new version 48 now, see also this FAQ and How-To.

And if not, it will be deprecated when Mozilla turns off support for the old add-ons, right? By the way, as scroblr is not available in the Mozilla add-on store, how would you install it in Firefox then?

num4rk commented 8 years ago

@cgravolet Whether there is a possibility of addition this extension to the official Firefox add-ons list? Otherwise, users have to install it as an unsigned extension manually, as far as i understand.

num4rk commented 8 years ago

For those who want to install the unsigned extension, please keep in mind that you can not do this in current stable Release of Firefox. Even with the xpinstall.signatures.required option turned "false". You'll have to switch to ESR build or developers / beta versions - https://wiki.mozilla.org/Add-ons/Extension_Signing

lmnoop commented 7 years ago

Oh man. Getting this to AMO where regular users could install it would be killer.

electron0zero commented 7 years ago

any updates on when it will be available on AMO?