cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

Support for Microsoft's Edge browser in Windows 10? #119

Open hans-juergen opened 8 years ago

hans-juergen commented 8 years ago

Microsoft has implemented the ability to use Chrome-like extensions in Edge which will be released today with the big Anniversary update for Windows 10. Some extensions are already available in the Windows 10 app store, most important of course adblockers.

Is there a chance that scroblr will support MS Edge in the future? According to Microsoft the necessary changes to an existing Chrome extension are easy to do.

hans-juergen commented 8 years ago

Update: there is a MS developer tool now available in the Windows 10 store to port Chrome extensions to Edge:

http://news.softpedia.com/news/microsoft-launches-app-to-convert-chrome-extensions-to-windows-10-edge-browser-507034.shtml

jjech commented 7 years ago

I looked into this today, and I am now successfully scrobbling tracks on Edge. Not many changes were needed. A couple of manual adjustments to the manifest.json and two new *.js files generated by Microsoft's conversion tool. I am not yet sure how to package this appropriately for a pull request back to the main project, but I am happy to report at least that this enhancement is achievable.

jjech commented 7 years ago

https://github.com/jjech/scroblr/commit/455a5379062727f20cc43b826e420332218a3222