search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
230 stars 62 forks source link

Scrobbling doesn't work on non-Bandcamp hostnames #125

Open drguildo opened 7 years ago

drguildo commented 7 years ago

If a Bandcamp page uses a non-Bandcamp hostname (e.g. http://music.musicofthemoon.com/), then scrobbling doesn't seem to work.

<meta property="fb:app_id" content="165661066782720"> seems like it might be a fairly simple and reliable way of checking for Bandcamp streaming pages.

cgravolet commented 7 years ago

It also means updating the permissions so scroblr initializes on every website that you visit, and last time I tried that it made a lot of users very upset.

bonyboy commented 7 years ago

@cgravolet would there a way to track it from bandcamp.com so that if you did a search for something like ESPRIT 空想 that it would track the next url after you visit (or search from) the bandcamp url?

bdukes commented 7 years ago

@bonyboy, no, this is about the permissions you grant the extension when you install or upgrade it. In order to have Scroblr know anything about the page on some arbitrary URL, the extension has to tell Chrome to give it access to pages on every domain, whereas right now it's restricted just to a list of music domains. Chrome's extension model doesn't let the extension get permissions to a new domain in the midst of browsing, so it doesn't help to look for something on the current page, unfortunately.

bonyboy commented 7 years ago

@bdukes I see what you're saying. Thanks for taking the time to explain it to me.