search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

Album Art is never displayed #142

Open grantbacon opened 5 years ago

grantbacon commented 5 years ago

I notice that there's never album art displayed, but a few sites you can easily retrieve album art from (spotify, soundcloud). I'm not sure of others.

I see some existing code that looks like it was trying to accomplish this; I may try to submit a PR to include this if I can figure it out.

Any objections or suggestions are appreciated. :)

cgravolet commented 5 years ago

If I recall (I may be wrong), this is the commit that broke the album art. It fixed another problem, and there was some refactoring I planned to do to how it retrieves album art, but I never got around to it. Feel free to take a look at it, I don't have much time these days to devote to scroblr. Last.fm has an API to retrieve album art from, which is what scroblr uses, so would prefer to continue using that, there are just some bugs that need to be fixed.