search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

npm run build fails #144

Open SeanPhilippi opened 3 years ago

SeanPhilippi commented 3 years ago

I cloned the repo, and ran 'npm i' inside the scroblr directory. I have done this on another computer successfully in the past. I am trying to install scroblr on my work (Windows 10) computer.

Here's the error when I try 'npm run build':

Loading "jpm.js" tasks...ERROR

ReferenceError: primordials is not defined Warning: Task "jpm:xpi" not found. Use --force to continue.

Aborted due to warnings. npm ERR! code ELIFECYCLE npm ERR! errno 3 npm ERR! scroblr@2.2.7 build: grunt npm ERR! Exit status 3 npm ERR! npm ERR! Failed at the scroblr@2.2.7 build script. npm ERR! This is probably not a problem with npm. There is likely additional log ging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\sphilippi\AppData\Roaming\npm-cache_logs\2021-06-08T14_59 _02_249Z-debug.log

bdukes commented 3 years ago

The "primordials is not defined" error comes from running Gulp 3 on Node.js 12+. You'll want to use a lower version of Node.js (probably v10.x), assuming you don't want to create a pull request to upgrade this project to Gulp 4. Hope it helps!

bdukes commented 3 years ago

I guess this project is using Grunt, rather than Gulp, but the same fix should work (though upgrading to the latest Grunt is probably less work than upgrading to Gulp 4, FYI).