search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

Add support for 8tracks. #25

Closed michaelherold closed 11 years ago

michaelherold commented 11 years ago

I've added support for 8tracks as requested in #18. Based off of the Songza plugin.

One thing that I did notice: it doesn't look like the "percent" Track attribute is used anywhere anymore. As far as I was able to trace, the usage of "percent" went away way back in 75c0c6ad6a (when the pollSongInfo method was rewritten during your refactor to plugins) and never came back. Was this on purpose?

I've tested my changes and the extension does scrobble tracks when finished, though the "Now listening to" status disappears after a few seconds.

cgravolet commented 11 years ago

If percent went away then that was probably an oversight, it should at least be used in the trackShouldBeScrobbled() method to determine if 50% of the song had been listened to. Since I no longer display the duration on the popup, didn't need any of that fancy math to calculate the duration estimate anymore.