search

cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
229 stars 62 forks source link

Add Grooveshark support. #77

Closed stellatigre closed 9 years ago

stellatigre commented 9 years ago

Simple Grooveshark support. I noticed there was already an icon (which was old, i updated it), but not a script, for Grooveshark ? Searched around the repo and didn't see support for it anywhere.

So I looked at the site - the new design is simple to scrape. Updated all the files as per the example commit for adding a new site, hopefully they are correct - if not, let me know & I'll correct them.

grantbacon commented 9 years ago

I think grooveshark isn't supported because it has internal scrobble support and users forget they enabled it and end up double scrobbling On Mar 30, 2015 1:09 PM, "Stella Tigre" notifications@github.com wrote:

Simple Grooveshark support. I noticed there was already an icon (which was old, i updated it), but not a script, for Grooveshark ? Searched around the repo and didn't see support for it anywhere.

So I looked at the site - the new design is simple to scrape. Updated all the files as per the example commit for adding a new site, hopefully they

are correct - if not, let me know & I'll correct them.

You can view, comment on, or merge this pull request online at:

https://github.com/cgravolet/scroblr/pull/77 Commit Summary

  • Squashed commit for adding Grooveshark support.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/cgravolet/scroblr/pull/77.

cgravolet commented 9 years ago

@grantbacon is right, scroblr used to support Grooveshark, but it was removed a couple years ago when they added native last.fm support. Native scrobbling will almost always be more reliable than anything the extension can provide. By adding support to sites that already have scrobbling, it causes double scrobbles for people who don't disable one or the other, and adds another site that I (we) need to maintain in future versions of the extension.