search

cgre-aachen / gemgis

Spatial data processing for geomodeling
https://gemgis.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
259 stars 41 forks source link

[BUG] "create_depth_map_from_gempy" creates seemingly correct but very very small surfaces (wrong scale) #333

Open phasyn8 opened 3 months ago

phasyn8 commented 3 months ago

Describe the bug Visualization tool outputs wrong depth for: "create_depth_maps_from_gempy()"

The following line of code I believe is to blame:

1690: # Append depth to PolyData 1691: surf['Depth [m]'] = geo_model.solutions.raw_arrays.vertices[index][:, 2]\

The surfaces appear to still be correct but they occur in the wrong scale (much, much smaller)

To Reproduce Steps to reproduce the behavior:

  1. make: gempy model , geo_model
  2. define: surface_list [surface1, surface2, ...]
  3. create depth map with: "gg.visualization.create_depth_maps_from_gempy(geo_model, surfaces=surface_list)
  4. Display poly data surfaces:
  5. See that surfaces are very very small ( <<1 meter )

Expected behavior Surfaces should be scaled to the dimensional units used in the model extents

Desktop (please complete the following information):

github-actions[bot] commented 3 months ago

Hello and welcome! Thanks for posting your first issue in the GemGIS project! Someone from our developers will get back to you. If your question is support related, we may transfer it to the Discussions.

AlexanderJuestel commented 2 months ago

Dear @phasyn8, thanks for mentioning that. In efforts to make GemGIS compatible with the latest versions of GemPy, GeoPandas and NumPy, I will put this on the list of To-Dos

AlexanderJuestel commented 2 months ago

Fixed in https://github.com/cgre-aachen/gemgis/commit/3bd4087c10f831c50c84117103c26ec797c410ed