search

cgre-aachen / gemgis_data

This repository contains the data used in GemGIS
GNU Lesser General Public License v3.0
3 stars 2 forks source link

[JOSE] Badges issue #13

Closed BenjMy closed 1 year ago

BenjMy commented 1 year ago

xref https://github.com/openjournals/jose-reviews/issues/185

In the README file, I would expect the badges to link with the proper target i.e.:

AlexanderJuestel commented 1 year ago

Hello @BenjMy,

thanks for opening this issue. Does your issue imply that you would make the gemgis_data repo available on Pypi and via conda forge? As this repo only consists of tutorial materials, we have not considered adding a Pypi and conda forge solution yet.

What is your take on that?

BenjMy commented 1 year ago

Hello Alex,

As I'm not sure I made myself clear (sorry for that), I propose this issue be solved after reviewing the opened PR #22 😉

Initially, I did not mean to make the gemgis_data repo available on Pypi but I've seen you create one. After all, I think it might be relevant if you want to use gemgis-data as a package to fetch and prepare the data (with Pooch for instance) and keep dependencies out of gemgis core.

Please fell free to close the issue when the PR is solved!

AlexanderJuestel commented 1 year ago

Yeah, somehow, one was created but since there is no code in the repo and only data the previous question came up. But then I will continue working without having in mind to publish the gemgis_data repo on PyPi and fix the installation of gemgis with pip in the other issue and continue then with revising the remaining open tasks for me.

Thanks for the clarification