cgre-aachen / open_AR_Sandbox

open-AR-Sandbox is a project to enable haptic interaction with geoscientific content in AR-Sandboxes.
GNU Lesser General Public License v3.0
63 stars 39 forks source link

Margin Patches #61

Open otirmizi opened 2 years ago

otirmizi commented 2 years ago

Hello,

I saw this issue with the KinectV1 mentioned in another thread (briefly) but I can't seem to resolve it. The original poster managed to fix it by using a KinectV2. I am having the issue of the margin patches only taking up a quarter of the sensor image in the bottom left. Despite digging through the code (which I am still very new at), I couldn't find a way to make the initial margin patches line up with the sensor depth image extent. Any advice on how to proceed?

I have attached an image below for reference. Thanks Screenshot from 2021-12-14 10-33-34 !

SimonVirgo commented 2 years ago

Hello @otirmizi, I am not sure if I understand you correctly if you also have the flickering issue or not. If so, try using the Chrome browser, The flickering seems to be a firefox issue. As for the margin patches, could you post the content of your Projector calibration file as well as the sensor calibration file saved with the settings above?

otirmizi commented 2 years ago

Good morning!

I apologize for the incredibly late response as I was out of the country over the holidays and did not have access to the files.

The flickering issue does occur sometimes during calibration but it stops whenever a module is loaded so that is not too much of an issue. The main issue is the margin patches being confined to the bottom corner. Here are the calibration files as requested.

my_projector_calibration.txt my_sensor_calibration.txt :

SimonVirgo commented 2 years ago

Hello @otirmizi, I guess the issue is related to the initial setup for the sensor. You said that you recently switched to a kinect v2, which has a different resolution than the original kinect sensor. However the calibration file you send was created for the kinect v1 sensor. So most probably initializing the sensor with the "kinectv2" keyword and creating a new sensor calibration file should resolve the issue. Best regards Simon

SimonVirgo commented 2 years ago

Ah, I just read your initial post again and realized that it was not you that switched to a kinect v2, sorry :-) Can you confirm that you are using a kinect v1?

otirmizi commented 2 years ago

@SimonVirgo no worries! Yes, I am using the Kinect v1. This setup is for the geoscience tutoring center at our university

SimonVirgo commented 2 years ago

okay, Thanks for the clarification. I do not have a kinect v1 to test at the moment, So it will be hard for me to reproduce the error. Can you check if the resolution of the projector (1920x1080) is actually the resolution that the projector is using?

SimonVirgo commented 2 years ago

could you try uncommenting the following 2 lines in update_panel_frame in calibration_sensor.py:

    # self.projector.ax.set_xlim(0, self.sensor.s_frame_width)
    # self.projector.ax.set_ylim(0, self.sensor.s_frame_height)
SimonVirgo commented 2 years ago

@otirmizi Did you manage to try the suggestion above?

otirmizi commented 2 years ago

Hi, thanks for checking in. I am using this software to upgrade the sandbox in our tutoring center on campus (we had the old uc davis linux sandbox setup in place). Since the semester has started and some classes currently need to use it, I have to leave it on the old setup for a while before I can continue working on it. I will let you know as soon as I am able to try it out!