cgre-aachen / pynoddy

pynoddy is a python package to write, change, and analyse kinematic geological modelling simulations performed with Noddy.
GNU General Public License v2.0
71 stars 31 forks source link

NoddyModel class? #3

Closed flohorovicic closed 9 years ago

flohorovicic commented 9 years ago

Define object (NoddyModel?) that combines input, computation, and output in a convenient way. Possibly: inheriting from both NoddyHistory and NoddyOutput (and NoddyGeophysics)? Should be possible, check!

markjessell commented 9 years ago

Hi flo

This would be very useful, but not sure if noddymodel is the right name? NoddyExperiment perhaps?

Cheers

Mark

Mark Jessell |WA Fellow/Winthrop Professor | Centre for Exploration Targeting M006 | 35 Stirling Highway x-apple-data-detectors://13/0 |x-apple-data-detectors://13/0 Crawley WA 6009 Australiax-apple-data-detectors://13/0 Tel +61 8 6488 5803tel:+61%208%206488%205803 | Fax +61 8 6488 1178tel:+61%208%206488%201178 E-mail Mark.Jessell@uwa.edu.aumailto:Mark.Jessell@uwa.edu.au|www.cet.edu.auhttp://www.cet.edu.au/

On 29 Nov 2014, at 5:37 pm, Florian Wellmann notifications@github.com<mailto:notifications@github.com> wrote:

Define object (NoddyModel?) that combines input, computation, and output in a convenient way. Possibly: inheriting from both NoddyHistory and NoddyOutput (and NoddyGeophysics)? Should be possible, check!

— Reply to this email directly or view it on GitHubhttps://github.com/flohorovicic/pynoddy/issues/3.

flohorovicic commented 9 years ago

Good idea - I think NoddyExperiment would be an appropriate name!

We could use a NoddyExperiment:

I read up a bit on multiple inheritance and I think we it would make sense to move to "new-style" class definitions before attempting the combination (should be completely downward compatible). I'll open that as a separate issue.

Cheers,

   --- Florian --- 
flohorovicic commented 9 years ago

Done! Feature is implemented and will be part of the new release (and explained in the paper with an example).