Use "Factory Bot" instead of "Factory Girl"

cgriego / active_attr

What ActiveModel left out

MIT License

1.2k stars 91 forks source link

Use "Factory Bot" instead of "Factory Girl" #168

Closed koic closed 5 years ago

koic commented 6 years ago

Factory Girl has been renamed to Factory Bot.

cf. https://github.com/thoughtbot/factory_bot/blob/master/NAME.md

koic commented 6 years ago

The test fails on Ruby REE's matrics. https://travis-ci.org/cgriego/active_attr/builds/423404870

Factory Bot requires Ruby 1.9.2 or higher but Ruby REE is Ruby 1.8.7. https://rubygems.org/gems/factory_bot

I'd like to propose removing the matrix of Ruby REE from Travis. Because both Ruby 1.8.7 and Rails 3 are EOL.

What do you think about this?

cgriego commented 5 years ago

I've prided myself on maintaining a high degree of compatibility, but yeah it's definitely time to drop Ruby 1.8. I dropped REE support upstream and then merged. Thanks for the contribution!