search

cgrima / subradar

Tools for subsurface radar processing
MIT License
3 stars 3 forks source link

hdf5storage not called out in package requirements #9

Open gregoryng opened 6 months ago

gregoryng commented 6 months ago

https://github.com/cgrima/subradar/blob/ff2683639fffa05a541008325b4f3df3e00501da/subradar/simulation/trento.py#L8

This package doesn't get installed even though it is required. Ideally it would be nice if the code could be rewritten not to need it and could just use h5py? But maybe that is too much work.

So I think you need to add something to the pip setup.

https://github.com/cgrima/subradar/blob/ff2683639fffa05a541008325b4f3df3e00501da/setup.py#L23

gregoryng commented 6 months ago

I'm also having trouble finding labellines:

https://github.com/cgrima/subradar/blob/ff2683639fffa05a541008325b4f3df3e00501da/subradar/fractal.py#L14

It looks like there are a lot of imports in fractal that ought to get removed.

cgrima commented 5 months ago

Looking at hdf5 right now. In the mean time pip install matplotlib-label-lines.