search

cgrindel / bazel-starlib

Rules, macros, and APIs that are useful for the implementation of Bazel repositories.
Apache License 2.0
18 stars 2 forks source link

33 test failures on windows due to diff_test case sensitivity issue #445

Open peakschris opened 3 months ago

peakschris commented 3 months ago

33 tests are failing on windows because skydoc is writing CRLF line endings, whilst the expected files are in repo with LF endings.

bazel --windows_enable_symlinks test //doc/shlib:execute_binary.md_difftest --enable_runfiles

INFO: From Testing //doc/shlib:execute_binary.md_difftest:
==================== Test output for //doc/shlib:execute_binary.md_difftest:
FINDSTR: /= ignored
FINDSTR: /" ignored
FINDSTR: /= ignored
FINDSTR: /" ignored
FAIL: files "doc/shlib/execute_binary.md" and "doc/shlib/execute_binary.md_" differ.

bazel --windows_enable_symlinks test //doc/shlib:execute_binary.md_difftest --noenable_runfiles

INFO: From Testing //doc/bazeldoc:build_rules_overview.md_difftest:
==================== Test output for //doc/bazeldoc:build_rules_overview.md_difftest:
FAIL: files "doc/bazeldoc/build_rules_overview.md" and "doc/bazeldoc/build_rules_overview.md_" differ.
================================================================================

This issue would be fixed by https://github.com/bazelbuild/bazel-skylib/pull/527, if approved and upstreamed

Failures

//doc/bazeldoc:api.md_difftest                                           FAILED in 0.8s
    ERROR   .doc/bazeldoc/api.md_difftest-test.bat (0.0s)
//doc/bazeldoc:build_rules_overview.md_difftest                          FAILED in 0.7s
    ERROR   .doc/bazeldoc/build_rules_overview.md_difftest-test.bat (0.0s)
//doc/bazeldoc:doc_utilities.md_difftest                                 FAILED in 0.7s
    ERROR   .doc/bazeldoc/doc_utilities.md_difftest-test.bat (0.0s)
//doc/bazeldoc:providers.md_difftest                                     FAILED in 0.8s
    ERROR   .doc/bazeldoc/providers.md_difftest-test.bat (0.0s)
//doc/bzlformat:rules_and_macros_overview.md_difftest                    FAILED in 0.7s
    ERROR   .doc/bzlformat/rules_and_macros_overview.md_difftest-test.bat (0.0s)
//doc/bzllib:api.md_difftest                                             FAILED in 0.8s
    ERROR   .doc/bzllib/api.md_difftest-test.bat (0.0s)
//doc/bzllib:bazel_labels.md_difftest                                    FAILED in 0.8s
    ERROR   .doc/bzllib/bazel_labels.md_difftest-test.bat (0.0s)
//doc/bzllib:filter_srcs.md_difftest                                     FAILED in 0.8s
    ERROR   .doc/bzllib/filter_srcs.md_difftest-test.bat (0.0s)
//doc/bzllib:lists.md_difftest                                           FAILED in 0.7s
    ERROR   .doc/bzllib/lists.md_difftest-test.bat (0.0s)
//doc/bzllib:rules.md_difftest                                           FAILED in 0.5s
    ERROR   .doc/bzllib/rules.md_difftest-test.bat (0.0s)
//doc/bzllib:src_utils.md_difftest                                       FAILED in 0.7s
    ERROR   .doc/bzllib/src_utils.md_difftest-test.bat (0.0s)
//doc/bzlrelease:api.md_difftest                                         FAILED in 0.8s
    ERROR   .doc/bzlrelease/api.md_difftest-test.bat (0.0s)
//doc/bzlrelease:create_release.md_difftest                              FAILED in 0.7s
    ERROR   .doc/bzlrelease/create_release.md_difftest-test.bat (0.0s)
//doc/bzlrelease:generate_release_notes.md_difftest                      FAILED in 0.7s
    ERROR   .doc/bzlrelease/generate_release_notes.md_difftest-test.bat (0.0s)
//doc/bzlrelease:generate_workspace_snippet.md_difftest                  FAILED in 0.8s
    ERROR   .doc/bzlrelease/generate_workspace_snippet.md_difftest-test.bat (0.0s)
//doc/bzlrelease:hash_sha256.md_difftest                                 FAILED in 0.7s
    ERROR   .doc/bzlrelease/hash_sha256.md_difftest-test.bat (0.0s)
//doc/bzlrelease:release_archive.md_difftest                             FAILED in 0.7s
    ERROR   .doc/bzlrelease/release_archive.md_difftest-test.bat (0.0s)
//doc/bzlrelease:rules.md_difftest                                       FAILED in 0.8s
    ERROR   .doc/bzlrelease/rules.md_difftest-test.bat (0.0s)
//doc/bzlrelease:update_readme.md_difftest                               FAILED in 0.8s
    ERROR   .doc/bzlrelease/update_readme.md_difftest-test.bat (0.0s)
//doc/bzltidy:rules_and_macros_overview.md_difftest                      FAILED in 0.8s
    ERROR   .doc/bzltidy/rules_and_macros_overview.md_difftest-test.bat (0.0s)
//doc/shlib:api.md_difftest                                              FAILED in 0.8s
    ERROR   .doc/shlib/api.md_difftest-test.bat (0.0s)
//doc/shlib:execute_binary.md_difftest                                   FAILED in 0.6s
    ERROR   .doc/shlib/execute_binary.md_difftest-test.bat (0.0s)
//doc/shlib:rules.md_difftest                                            FAILED in 0.6s
    ERROR   .doc/shlib/rules.md_difftest-test.bat (0.0s)
//doc/updatesrc:api.md_difftest                                          FAILED in 0.9s
    ERROR   .doc/updatesrc/api.md_difftest-test.bat (0.0s)
//doc/updatesrc:providers_overview.md_difftest                           FAILED in 0.7s
    ERROR   .doc/updatesrc/providers_overview.md_difftest-test.bat (0.0s)
//doc/updatesrc:rules_and_macros_overview.md_difftest                    FAILED in 0.9s
    ERROR   .doc/updatesrc/rules_and_macros_overview.md_difftest-test.bat (0.0s)
//doc/updatesrc:update_srcs.md_difftest                                  FAILED in 0.8s
    ERROR   .doc/updatesrc/update_srcs.md_difftest-test.bat (0.0s)
//tests/bzlformat_tests/tools_tests/missing_pkgs_tests/common_tests:bzlformat_BUILD_bazel_fmttest FAILED in 0.6s
    ERROR   .tests/bzlformat_tests/tools_tests/missing_pkgs_tests/common_tests/bzlformat_BUILD_bazel_fmttest-test.bat (0.0s)
//tests/bzlrelease_tests/rules_tests/generate_release_notes_tests:bzlformat_BUILD_bazel_fmttest FAILED in 0.6s
    ERROR   .tests/bzlrelease_tests/rules_tests/generate_release_notes_tests/bzlformat_BUILD_bazel_fmttest-test.bat (0.0s)
//tests/bzlrelease_tests/rules_tests/generate_workspace_snippet_tests:bzlformat_BUILD_bazel_fmttest FAILED in 0.5s
    ERROR   .tests/bzlrelease_tests/rules_tests/generate_workspace_snippet_tests/bzlformat_BUILD_bazel_fmttest-test.bat (0.0s)
//tests/bzlrelease_tests/rules_tests/release_artifact_tests:bzlformat_BUILD_bazel_fmttest FAILED in 0.8s
    ERROR   .tests/bzlrelease_tests/rules_tests/release_artifact_tests/bzlformat_BUILD_bazel_fmttest-test.bat (0.0s)
//tests/markdown_tests/markdown_generate_toc_tests:structured_custom_toc_header_test FAILED in 0.4s
    ERROR   .tests/markdown_tests/markdown_generate_toc_tests/structured_custom_toc_header_test-test.bat (0.0s)
//tests/markdown_tests/markdown_generate_toc_tests:structured_keep_toc_header_entry_test FAILED in 0.5s
    ERROR   .tests/markdown_tests/markdown_generate_toc_tests/structured_keep_toc_header_entry_test-test.bat (0.0s)
//tests/markdown_tests/markdown_generate_toc_tests:structured_no_toc_header_test FAILED in 0.5s
    ERROR   .tests/markdown_tests/markdown_generate_toc_tests/structured_no_toc_header_test-test.bat (0.0s)
Test cases: finished with 295 passing and 34 failing out of 329 test cases

A typical difference is:

D:\workdir\github\forks\bazel-starlib2>diff "D:\workdir\github\forks\bazel-starlib2\doc\bazeldoc\build_rules_overview.md" "D:\udu\b\356umzpb\execroot\_main\bazel-out\x64_windows-fastbuild\bin\doc\bazeldoc\build_rules_overview.md_" | cat -v
1,15c1,15
< <!-- Generated with Stardoc, Do Not Edit! -->
< # Build Rules
<
< The macros described below are used to generate, test and copy
< Starlark documentation.
<
< On this page:
<
<   * [doc_for_provs](#doc_for_provs)
<   * [stardoc_for_prov](#stardoc_for_prov)
<   * [stardoc_for_provs](#stardoc_for_provs)
<   * [write_doc](#write_doc)
<   * [write_file_list](#write_file_list)
<   * [write_header](#write_header)
<
---
> <!-- Generated with Stardoc, Do Not Edit! -->^M
> # Build Rules^M
> ^M
> The macros described below are used to generate, test and copy ^M
> Starlark documentation.^M
> ^M
> On this page:^M
> ^M
>   * [doc_for_provs](#doc_for_provs)^M
>   * [stardoc_for_prov](#stardoc_for_prov)^M
>   * [stardoc_for_provs](#stardoc_for_provs)^M
>   * [write_doc](#write_doc)^M
>   * [write_file_list](#write_file_list)^M
>   * [write_header](#write_header)^M
> ^M
peakschris commented 3 months ago

This issue would be fixed by https://github.com/bazelbuild/bazel-skylib/pull/527, if approved and upstreamed