cgrindel / rules_spm

Provide a means for integrating external Swift packages built by Swift Package Manager into Bazel build using rules_swift.
Apache License 2.0
58 stars 13 forks source link

module.modulemap fails encountering submodule #145

Open pswaminathan opened 2 years ago

pswaminathan commented 2 years ago

Fails with:

Error in fail: Errors parsing the /private/var/tmp/_bazel_p/c1a9d93c5d307e720ae1d0573bce325b/external/swift_pkgs/spm_build/checkouts/grpc-SwiftPM/./include/grpc/module.modulemap. struct(child_errors = [], msg = "Unexpected prefix tokens found at end of module member block. tokens: [struct(type = \"reserved\", value = \"module\"), struct(type = \"operator\", value = \"*\"), struct(type = \"curly_bracket_open\", value = None)]")

Example from gRPC:


framework module grpc {
  umbrella header "grpc.h"

  header "support/alloc.h"
  header "support/atm.h"
  header "support/cpu.h"
  header "support/log.h"
  header "support/log_windows.h"
  header "support/port_platform.h"
  header "support/string_util.h"
  header "support/sync.h"
  header "support/sync_abseil.h"
  header "support/sync_generic.h"
  header "support/thd_id.h"
  header "support/time.h"
  header "impl/codegen/atm.h"
  header "impl/codegen/fork.h"
  header "impl/codegen/gpr_slice.h"
  header "impl/codegen/gpr_types.h"
  header "impl/codegen/log.h"
  header "impl/codegen/port_platform.h"
  header "impl/codegen/sync.h"
  header "impl/codegen/sync_abseil.h"
  header "impl/codegen/sync_generic.h"
  header "impl/codegen/byte_buffer.h"
  header "impl/codegen/byte_buffer_reader.h"
  header "impl/codegen/compression_types.h"
  header "impl/codegen/connectivity_state.h"
  header "impl/codegen/grpc_types.h"
  header "impl/codegen/propagation_bits.h"
  header "impl/codegen/slice.h"
  header "impl/codegen/status.h"
  header "impl/codegen/atm.h"
  header "impl/codegen/fork.h"
  header "impl/codegen/gpr_slice.h"
  header "impl/codegen/gpr_types.h"
  header "impl/codegen/log.h"
  header "impl/codegen/port_platform.h"
  header "impl/codegen/sync.h"
  header "impl/codegen/sync_abseil.h"
  header "impl/codegen/sync_generic.h"
  header "grpc_security.h"
  header "byte_buffer.h"
  header "byte_buffer_reader.h"
  header "compression.h"
  header "fork.h"
  header "grpc.h"
  header "grpc_posix.h"
  header "grpc_security_constants.h"
  header "load_reporting.h"
  header "slice.h"
  header "slice_buffer.h"
  header "status.h"
  header "support/workaround_list.h"
  header "census.h"

  textual header "support/atm_gcc_atomic.h"
  textual header "support/atm_gcc_sync.h"
  textual header "support/atm_windows.h"
  textual header "support/sync_custom.h"
  textual header "support/sync_posix.h"
  textual header "support/sync_windows.h"
  textual header "impl/codegen/atm_gcc_atomic.h"
  textual header "impl/codegen/atm_gcc_sync.h"
  textual header "impl/codegen/atm_windows.h"
  textual header "impl/codegen/sync_custom.h"
  textual header "impl/codegen/sync_posix.h"
  textual header "impl/codegen/sync_windows.h"
  textual header "impl/codegen/atm_gcc_atomic.h"
  textual header "impl/codegen/atm_gcc_sync.h"
  textual header "impl/codegen/atm_windows.h"
  textual header "impl/codegen/sync_custom.h"
  textual header "impl/codegen/sync_posix.h"
  textual header "impl/codegen/sync_windows.h"

  export *
  module * { export * }
}
cgrindel commented 2 years ago

Related to #27.

Yeah. I didn't get around to implementing this yet.

pswaminathan commented 2 years ago

I have something that might work in pswaminathan/rules_spm#1. I've PRed it on my repo because its base is my other PR.

Edit: Just PRed as #146