search

cgrok / clashroyale

Async + Sync wrapper for royaleapi.com and the CR official API
MIT License
47 stars 19 forks source link

requirements.txt and setup.py list different package version numbers #12

Closed jykntr closed 6 years ago

jykntr commented 6 years ago

aiohttp and python-box have different versions listed in setup.py & requirements.txt. I believe requirements.txt Is correct.

https://github.com/cgrok/clashroyale/blob/20f64893342b19d8aeaaa2e31ead1b71d617ae88/setup.py#L17 https://github.com/cgrok/clashroyale/blob/20f64893342b19d8aeaaa2e31ead1b71d617ae88/requirements.txt#L1-L2

fourjr commented 6 years ago

Will change soon, you can help by doing a PR.

requirements.txt has the right versions

fourjr commented 6 years ago

Fixed in https://github.com/cgrok/clashroyale/commit/b8d096b5af503cc2155add1046ecb6540a91866a