search

cgrok / clashroyale

Async + Sync wrapper for royaleapi.com and the CR official API
MIT License
47 stars 19 forks source link

Equality Tests? #2

Closed kyb3r closed 6 years ago

kyb3r commented 6 years ago

Should we put equality tests for models?

player1 = client.get_profile('2CCP')
player2 = client.get_profile('2CCP')
assert player1 == player2

Should we test by tag or if the data is the exact same?

fourjr commented 6 years ago

Added tests to compare by tag with blocking client in https://github.com/cgrok/clashroyale/commit/9796e5d7ae0fa090221355e590f564f6a6ec9a6b