cgrok / clashroyale

Async + Sync wrapper for royaleapi.com and the CR official API

MIT License

47 stars 19 forks source link

OfficialAPI: add river race and river race log endpoints #41

Open gogaz opened 3 years ago

gogaz commented 3 years ago

Changes Description

Update war logs URL to match the latest version of Clash Royale Given that the endpoint data format for river races slightly differs from previous clan wars, I advocate for new methods over modificating get_clan_war* methods.

Type of PR

[ ] Bug Fix
[x] Feature Addition

Checklist

[x] Docstrings added (NumpyDoc)
[ ] ~~If necessary, add to the documentation files~~
[X] Add to the CHANGELOG file
[X] Tox checked

gogaz commented 3 years ago

@fourjr any chance to have this reviewed any time soon?

igonro commented 3 years ago

How is this going @fourjr ? I'm interested in using it in my project.

fourjr commented 3 years ago

Hey, I've been busy over the past week. Will review and push to PyPi by end of next week.

fourjr commented 3 years ago

Hey, sorry for the late reply, why isn't the get_clan_war method removed? From the api documentation, /currentwar is no longer in use.

gogaz commented 3 years ago

@fourjr good catch, I hadn't tested it! What do you think we should do with get_clan_warlog? It's been showing possibilities to bring it back are being investigated for almost 3 monthes now so it sounds like it's not going to be back again...

PaKostya commented 2 years ago

What status with this branch?