cgroschupp / go-client-confluent-cloud

MIT License
13 stars 19 forks source link

Add support for managing ACLs #20

Closed aliellis closed 3 years ago

aliellis commented 3 years ago

Hey everyone, I noticed that you don't currently have support for interacting with ACLs so here's something :)

This is all reverse engineered from the calls ccloud makes itself, though confluent themselves don't seem to offer this functionality, even in the early access v2 API.

It's relatively straightforward, you need an access token from the main endpoint, which you then pass to the cluster endpoint that you want to manage so I've made a new client to handle this, smooth sailing after that.

I've tested this locally with some sample scripts that I can share if people want them/update the readme, otherwise please let me know if you have any other questions or feedback, I'm new to go so if I've structured/called things weirdly call me out on it, I've tried to follow established patterns where possible.

EDIT: i totally missed that there's a kafka provider that provides this functionality 🤦 I'm new to the world of kafka and confluent, can anyone confirm that the kafka provider's ACL is the same as confluent's and that this PR is useless? 😆