cgross / angular-notify

Minimalistic and extensible notification service for Angular.
http://cgross.github.io/angular-notify/demo/
MIT License
432 stars 99 forks source link

Per-notification 'duration' can't be set to 0 #25

Open tiliv opened 9 years ago

tiliv commented 9 years ago

This line makes a 0 fall back to the global config.

https://github.com/cgross/angular-notify/blob/4d159b6ebec256409341ba707a9838e93827f523/angular-notify.js#L21

args.duration = args.duration ? args.duration : defaultDuration;
iamwillpowell commented 9 years ago

You can pass duration as string to work around this bug.

notify({message: 'Hello World', duration: '0'});
jasonstockman commented 9 years ago

This was an issue I ran into, and this comment helped a lot.

JulienDeray commented 8 years ago

:+1: