search

cgross / angular-notify

Minimalistic and extensible notification service for Angular.
http://cgross.github.io/angular-notify/demo/
MIT License
432 stars 99 forks source link

protractor tests : using $interval instead of $timeout for notify duration management #41

Open mpellerin42 opened 9 years ago

mpellerin42 commented 9 years ago

Hi,

I use this module in my application, and I started to write e2e tests with protractor. There is no problem when writing tests for function using notification which stay on screen, but notification with duration attribute are not testable. This issue comes from the $timeout service to manage notification duration : protractor waits for $timeouts (and $http) before to run actions and expectation. So notification with duration can't be tested as they disappears before protractor tests them. In documentation (https://github.com/angular/protractor/blob/master/docs/timeouts.md), protractor team precognise to replace $timeout services by $interval services to this kind of issue.

Can you try that to allow protractor testing of notifications with duration ?

holm commented 9 years ago

:+1: We are running into the same issue, and using $interval would solve a big headache for us.

holm commented 9 years ago

I have made a fork that changes to $interval here: https://github.com/peakon/angular-notify

samudurand commented 8 years ago

Coud that be used in the main branch ? Otherwise we will have to implement our own...

mpospelov commented 8 years ago

@holm thanks for your fork, it works for me :+1: