search

cgross / angular-prompt

Angular service to easily display input prompts and confirmation modals.
http://cgross.github.io/angular-prompt/demo
MIT License
52 stars 41 forks source link

Hard coded start & end symbols can cause rendering issues #7

Open toddrun opened 9 years ago

toddrun commented 9 years ago

I use different start and end symbols in my angular app:

config(function($interpolateProvider){
    $interpolateProvider.startSymbol('{[{').endSymbol('}]}');
})

Unfortunately, that isn't honored by angular-prompt. It would be helpful to have the start and end symbols dynamically set.

AndreasLoukakis commented 9 years ago

@toddrun a frew days before you submited the issue, I made a pull request fixing this exact same thing. Just letting you know here in case you would like to take a look as @cgross hasn't checked it out obviously.

toddrun commented 9 years ago

@AndreasLoukakis, that's awesome! The project where I'm using angular-prompt is currently in code freeze, but hopefully your fix will get in soon.