search

cgross / generator-cg-angular

Yeoman generator for Enterprise Angular projects.
MIT License
592 stars 198 forks source link

Added SASS support #86

Closed unclejustin closed 3 years ago

sdoxsee commented 10 years ago

Enjoying the PR. Thanks! A suggestion for the PR (that may get it accepted more easily/quickly) would be to remove the auto-generation of LESS files when SASS is chosen and maybe to update the readme for the generator to reflect your changes.

unclejustin commented 10 years ago

Good call. I actually just got removing the less files working on my local. I'll see if I can get it rolled in soon.

sdoxsee commented 10 years ago

Great!

I just noticed that the app.css is generated not just into the temp folder but also into the root folder beside app.scss, etc.. I can .gitignore the app.css file it shouldn't need to be copied to root (IMO). What do you think?

cgross commented 10 years ago

Thanks for the PR. I am definitely happy to have SASS support in the generator. The more complete you can get the support the more eager I am to merge in the PR. FWIW, I also did start on SASS support in the v3.2 branch earlier this year and just never found the time to finish it. You might want to look over that code too.

One of the things I would be happy to see, would be to change the existing LESS integration so that is doesn't use the less.js Githubissues.

  • Githubissues is a development platform for aggregating issues.