search

cgross / generator-cg-angular

Yeoman generator for Enterprise Angular projects.
MIT License
592 stars 198 forks source link

upgrading to angularjs 1.3.x #87

Open marcdexet-cnrs opened 10 years ago

marcdexet-cnrs commented 10 years ago

Hi, Is an upgrade is planned to use ng 1.3.x ?

Tx

cgross commented 9 years ago

Yes. Sometime soon.

joeljeske commented 9 years ago

+1 What is the hold up? What is necessary beyond updating bower.json? I'd be willing to put in some hours for this to happen.

AnBauer commented 9 years ago

The problem is the dependency for angular-bootstrap.This lib supports only 1.2.x yet.

ragefuljoe commented 9 years ago

depending on what parts of uibootstrap you need it's "safe" to upgrade to 1.3.x. Some stuff like datepicker have quickfixes, others kinda borked, so ymmv.

terales commented 9 years ago

angular-bootstrap.0.13.0 added support of angular 1.3

Is there are any problems with pull request from @adnasa?

adnasa commented 9 years ago

The problem is the dependency for angular-bootstrap.This lib supports only 1.2.x yet.

Do you have resource supporting this statement? 0.13.0 has been out for a little while now and even the site mentioned the following:

AngularJS (requires AngularJS 1.3.x, tested with 1.3.13). 0.12.0 is the last version of this library that supports AngularJS 1.2.x.

I don't see any reason for waiting any longer

@terales Is PR #71 relevant/up to date to follow up on this issue? of course, I can spend some amend my PR if needed ;)

Take care!

terales commented 9 years ago

@adnasa, I've already used your PR as template to update my app dependencies. But I can't merge it to main generator repository, so I stated a question to maintainers.

I think they can merge it without any problems and with value for all who starts new app now.

adnasa commented 9 years ago

okay. then we'll wait for @cgross after he's finished consulting his crystal ball of enlightenment :grinning: