search

cgrossde / Pullover

The unofficial multi-platform Pushover desktop client
382 stars 71 forks source link

Doesn't notify you when disconnected #114

Closed mehdi9000 closed 6 years ago

mehdi9000 commented 6 years ago

This application has shown a status of "OFFLINE" several times now while the internet is running & you have no way of knowing unless you check manually.

See: https://i.snag.gy/DxzTiP.jpg

There should be a popup indicator that tells you when it is no longer connected, & also allow for auto-reconnect should it disconnect.

This is a major issue because one may miss major alerts simply because Pullover is disconnected. I have seen this happen several times now.

Another useful feature would be to hover over the tray icon in the top menu bar (at least on Mac), & a little preview (without clicking) that shows connection status would be useful.

From log file: "Fri Mar 30 2018 19:42:55 GMT-0400 (EDT) ConnectionManager 'Fetch failed - offline' { [FetchNotificationsFailed: Fetch notification request failed] name: 'FetchNotificationsFailed', cause: { [Error: connect ETIMEDOUT 207.244.109.177:443] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect', address: '207.244.109.177', port: 443 } } Fri Mar 30 2018 19:42:55 GMT-0400 (EDT) ConnectionManager 'Offline' Fri Mar 30 2018 19:42:55 GMT-0400 (EDT) PushoverWSClient 'Socket closed' Fri Mar 30 2018 19:43:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:43:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:44:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:44:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:45:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:45:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:46:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:46:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:47:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:47:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:48:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:48:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:49:25 GMT-0400 (EDT) ConnectionManager 'Checking internet connection' Fri Mar 30 2018 19:49:55 GMT-0400 (EDT) ConnectionManager 'Checking internet connection'"

cgrossde commented 6 years ago

@mastermood Thanks for your report. I have a few questions:

Pullover does auto-reconnect when:

I think the mechanism to detect if internet is available doesn't work on your machine. My guess is, that you are in a corporate network that filters certain packets and breaks the internet connection check feature of Pullover.

mehdi9000 commented 6 years ago

I'm not on corporate, just home network. MacOS 10.12.6, no VPN, no firewall. Restarting Pullover will treat the problem.

Is it possible a popup notification comes up if it gets disconnected? And also hovering over the tray bar icon showing the status like this: https://snag.gy/9O37uZ.jpg ?

Why does it fail to reconnect once it disconnects while it's connected to the internet.

cgrossde commented 6 years ago

You could add a notification on disconnect, the relevant file to look at would be: https://github.com/cgrossde/Pullover/blob/master/src/app/services/ConnectionManager.js This is also the code that handles the reconnect after sleep or loss of internet connection.

With that said I won't add a notification on disconnect to the regular Pullover builds because the auto reconnect seems to work for the rest of the Pullover users and I sadly don't have the time to track down the issue you are running into. Feel free to create a PR if you found the cause why autoreconnect doesn't work on your system. Will close this issue.