search

cgrushko / proto_library

Apache License 2.0
39 stars 20 forks source link

Appears not to work on windows #3

Closed photex closed 2 years ago

photex commented 6 years ago

Just cloned and tried to build. Don't know a lot about Bazel yet so I'm not sure where /Wwrite-strings is even being specified.

I'm happy to help triage whenever I become more proficient with the system.

C:\projects\proto_library>bazel build //src:person_cc_proto
INFO: Found 1 target...
ERROR: C:/users/chip.collier/appdata/local/temp/_bazel_chip.collier/7oy6qvby/external/com_google_protobuf/BUILD:73:1: C++ compilation of rule '@com_google_protobuf//:protobuf_lite' failed (Exit 2).
cl : Command line error D8021 : invalid numeric argument '/Wwrite-strings'
Target //src:person_cc_proto failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.901s, Critical Path: 0.08s

C:\projects\proto_library>bazel build //src
ERROR: no such target '//src:src': target 'src' not declared in package 'src' defined by C:/projects/proto_library/src/BUILD.
INFO: Elapsed time: 0.512s

C:\projects\proto_library>bazel build //src:person_java_proto
INFO: Found 1 target...
ERROR: C:/users/chip.collier/appdata/local/temp/_bazel_chip.collier/7oy6qvby/external/com_google_protobuf_java/BUILD:73:1: C++ compilation of rule '@com_google_protobuf_java//:protobuf_lite' failed (Exit 2).
cl : Command line error D8021 : invalid numeric argument '/Wwrite-strings'
Target //src:person_java_proto failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 15.177s, Critical Path: 0.19s
cgrushko commented 6 years ago

@xfxyjwf for protobuf @philwo for windows (I think?)

photex commented 6 years ago

Protobuf from master built fine. err... at least protobuf, and protoc did. I didn't test extensively.

cgrushko commented 6 years ago

Ah, then it could be as simple as updating the commit hashes in WORKSPACE.

On Sep 24, 2017 15:31, "Chip Collier" notifications@github.com wrote:

Protobuf from master built fine. err... at least protobuf, and protoc did. I didn't test extensively.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cgrushko/proto_library/issues/3#issuecomment-331733489, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5_YY6phHiqkH-jPvTQQgJIBJTRJmv3ks5slq4WgaJpZM4Ph-8D .