search

cgs / evernote

A Ruby client for Evernote
MIT License
144 stars 20 forks source link

Small change in how config information is passed in. #5

Closed peetucket closed 13 years ago

peetucket commented 13 years ago

Remove need to have configuration parameters in a YML file, allow a generic hash to be passed in instead. Adjust readme file to describe changed usage.

cgs commented 13 years ago

I like the change. A couple of suggesions though. Can you 1) fix/update the broken tests in user_store_spec and 2) fix the indentation in the readme? Maybe something like this would be easier to read:

config = {
  'username' => 'YOUR_USERNAME',
  'password' => 'YOUR_PASSWORD',
  'consumer_key' => 'YOUR_CONSUMER_KEY_FROM_EVERNOTE',
  'consumer_secret' => 'YOUR_CONSUMER_SECRECT_FROM_EVERNOTE'
}

It would also be nice if this hash could use symbols for keys as the default, but also work with string keys. Thanks!

peetucket commented 13 years ago

Yup, good ideas. I just implemented them, but am having trouble getting the spec tests to run, even after installing the Jeweler gem. I'm on the latest version of Rails, Ruby 1.9, and just installed the latest rspec.

peetucket commented 13 years ago

Error is "no such file to load -- spec/rake/spectask" (line 23 of Rakefile)

d1 commented 13 years ago

The "no such file to load -- spec/rake/spectask" error is because this gem's specs use rspec1.

I just submitted a pull request to update to rspec2.

peetucket commented 13 years ago

Ahh, interesting, good find.

peetucket commented 13 years ago

Ahh, interesting, good find.

cgs commented 13 years ago

cool, I'll take another look at this.

cgs commented 13 years ago

Thanks guys. I'll push a new version of the gem out soon.