[Photorec] Wrong estimated time to completion (ETA)?

cgsecurity / testdisk

TestDisk & PhotoRec

https://www.cgsecurity.org/

GNU General Public License v2.0

1.58k stars 195 forks source link

[Photorec] Wrong estimated time to completion (ETA)? #27

Closed pabloab closed 6 years ago

pabloab commented 7 years ago

Like this guy on Askubuntu I'm trying to recover files from a external hard disk drive with some bad sectors: In my case my 1TB HDD connected with USB 3.0 will finish in... 5 years. If this is sadly true I suspect the user should receibe a warning. I also have a superfast SSD drive on my main computer, I wonder why photorec doesn't just make an image and work on the ssd.

pabloab commented 7 years ago

I was recommended to use ddrescue and work on generated disk image but before trying that alternative and after 3 hours of work photorec reach the "Recovery completed." (153 files recovered). So probably the algorithm that calculate ETA may need some adjustments.

cgsecurity commented 6 years ago

The ETA will never be reliable with bad sectors as their distribution on the disk is unknown.

pabloab commented 6 years ago

If become so unreliable to the point it say going to take five years then probably shouldn't display it at all. This is a bug IMO.