search

cgsecurity / testdisk

TestDisk & PhotoRec
https://www.cgsecurity.org/
GNU General Public License v2.0
1.58k stars 195 forks source link

[testdisk] Feature: Progress bar #38

Closed nwrox closed 6 years ago

nwrox commented 6 years ago

When you select to copy one or more files there is no indication of current progress or estimated time. Would be nice to have a progress bar like in the wget.

wget1

cgsecurity commented 6 years ago

There is an indication of progress: the number of files copied is updated in realtime.

nwrox commented 6 years ago

Sorry there is a indication as you said but I think that the number of copied files is not enough. If a progress bar like in the wget is too much is possible at least a eta count?

testdisk

cgsecurity commented 6 years ago

The number of files to copy is unknown when the copy starts. Counting the number of files before starting the copy may waste some time but the real problem is that the filesystem is not reliable, the disk may be damaged and parsing the directory structure may never complete. IMO it's better to recover some files than recovering nothing because the program tries to count the number of files to copy...

nwrox commented 6 years ago

@cgsecurity you say that the number of files to copy is unknown, but you must select the files that you want to copy right?

cgsecurity commented 6 years ago

If you are undeleting files from a FAT32 and select a single directory to recover, there may be a lot of files inside... Same thing is you choose an NTFS partition and List.

nwrox commented 6 years ago

Got your point, this can become expensive programmatically, so i think there's no way to add this feature, this issue can be closed now, thanks.