cgsecurity / testdisk

TestDisk & PhotoRec
https://www.cgsecurity.org/
GNU General Public License v2.0
1.55k stars 190 forks source link

Not enough space on connected USB drive when recovering (Windows Version, ophotorec) #99

Open leotulipan opened 3 years ago

leotulipan commented 3 years ago

Latest pre-compiled Win x64 Version-

Restoring to a standard (FAT32) External empty 512GB HDD from the local 2568GB SSD in Win10

I get "There is not enough space left! Please free disk space and/or choose another destination"

which is related to PSTATUS_ENOSPC switch/case here https://github.com/cgsecurity/testdisk/blob/master/src/qphotorec.cpp https://github.com/cgsecurity/testdisk/blame/master/src/phrecn.c

It might be related to the old open issue https://github.com/cgsecurity/testdisk/issues/9

image

as I only selected doc, pdf and zip as the file options I am guessing some >4GB zip/tmp file is being written and I cannot skip this part.

cgsecurity commented 3 years ago

https://github.com/cgsecurity/testdisk_documentation/blob/master/photorec.rst now contains "Avoid choosing a FAT32 filesystem for the destination as it doesn't handle file over 4 GB.". See https://www.cgsecurity.org/testdisk.pdf for the generated pdf

I don't plan to implement customizable file size limits.

What do you suggest to replace "There is not enough space left! Please free disk space and/or choose another destination" ? ""There is not enough space left! Please free disk space and/or choose another destination (Avoid FAT32)" ?

leotulipan commented 3 years ago

Thanks for the prompt reply Christophe,

let me start by saying I really appreciate the software and was already able to rescue a lot of data!

As more and more less tech-savvy people start using tools like this, and as external USB HDD are often pre-formatted FAT this is a real issue and was even confusing to me. If I had used an (internal) drive with ext4 on Linux I wouldn't have even noticed.

I am not a C programmer (html, js, php mostly), so excuse for only giving suggestions and not offering a PR

leotulipan commented 3 years ago

@cgsecurity I just retried the steps - this time with an NTFS formatted 65GB drive. After the restore of 207 files (about 1GB) it hangs again with not enough space? Any idea why this happens (latest 64bit version of photorec under win10 was used)

LMG7 commented 3 years ago

@leotulipan were you able to find a solution? I and using a NTFS HDD and am getting the same message :/