cgtobi / PyRMVtransport

:bus: Get transport information from opendata.rmv.de
MIT License
12 stars 6 forks source link

Compatibility for async_timeout 4.0.0 #47

Closed frenck closed 3 years ago

frenck commented 3 years ago

Ensures it works with async_timeout 4, which is now part of Home Assistant.

Noticed this one when working on Python 3.10 and a newer pip version:

ERROR: Cannot install -r requirements_test_all.txt (line 118), -r requirements_test_all.txt (line 24) and -r requirements_test_all.txt (line 54) because these package versions have conflicting dependencies.

The conflict is caused by:
    pyrmvtransport 0.3.2 depends on async-timeout
    adax 0.1.1 depends on async-timeout>=1.4.0
    aioguardian 1.0.8 depends on async_timeout<4.0.0 and >=3.0.1
    The user requested (constraint) async-timeout==4.0.0
sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.33 ⭐ 1.33 ⭐ 0.00
Method Length 44.29 ⭐ 44.29 ⭐ 0.00
Working memory 5.10 ⭐ 5.10 ⭐ 0.00
Quality 85.59% 85.59% 0.00%
Other metrics Before After Change
Lines 220 220 0
Changed files Quality Before Quality After Quality Change
RMVtransport/rmvtransport.py 85.59% ⭐ 85.59% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 (3d24a9d) into development (6724ea6) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           development       #47   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files                6         6           
  Lines              266       266           
=============================================
  Hits               266       266           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
RMVtransport/rmvtransport.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6724ea6...3d24a9d. Read the comment docs.