Closed cgtobi closed 2 years ago
β Merging this PR will decrease code quality in the affected files by 0.09%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.13 β | 0.14 β | 0.01 π |
Method Length | 47.42 β | 48.39 β | 0.97 π |
Working memory | 5.81 β | 5.85 β | 0.04 π |
Quality | 84.95% β | 84.86% β | -0.09% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 257 | 247 | -10 |
| Changed files | Quality Before | Quality After | Quality Change |
| --- | :---: | :---: | :---: |
| tests/test_bugs.py | 84.13% β | 84.13% β | 0.00% |
| tests/test_rmvtransport.py | 85.23% β | 85.12% β | -0.11% π|
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|
## Legend and Explanation
The emojis denote the absolute quality of the code:
- β excellent
- π good
- π poor
- β very poor
The π and π indicate whether the quality has improved or gotten worse with this pull request.
***
Please see our documentation [here](https://docs.sourcery.ai/GitHub/Quality-Report/) for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us [improve](https://research.typeform.com/to/j06Spdfr?type=quality_report&github_login=cgtobi&base_repo=https%3A%2F%2Fgithub.com%2Fcgtobi%2FPyRMVtransport.git&base_remote_ref=refs%2Fpull%2F55%2Fhead&base_ref=update_tests&base_sha=fe93b3d9d625f9ccf8eb7b0c39e0ff41c72d2e77&head_repo=https%3A%2F%2Fgithub.com%2Fcgtobi%2FPyRMVtransport.git&head_ref=sourcery%2Fupdate_tests&base_pr_number=55&base_pr_state=open) this quality report!
Merging #55 (fe93b3d) into development (4ef8ac9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## development #55 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 6 6
Lines 266 266
=============================================
Hits 266 266
Flag | Coverage Ξ | |
---|---|---|
unittests | 100.00% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 4ef8ac9...fe93b3d. Read the comment docs.
Signed-off-by: cgtobi cgtobi@gmail.com