[Feature Request] Allow more concurrent requests/threads for EXPORT and "Watching for changes"?

[klyco]

Hi there Carlos!

This is Ken from Kodi forums :-) Thanks again so much for this brilliant addon!

I currently have a TV and Movie library that is tens of thousands of files. When I export them, it takes a very long time (like 18-24 hours) on a Windows computer with 12th Gen i5 with 16Gb RAM. Also, when Google Drive is watching changes, and there are a load of them, it is slow. I suspect the bottleneck is the requests to Google.

Is it possible to have a setting, where we can choose how many concurrent requests/ threads are used for the EXPORT, and Watching Changes?

Alternatively, perhaps the fact that the TVShows and MOVIES are in the same export db slows it down? Maybe we could split into 2 databases? Although that maybe irrelevant.

Thanks in advance for your consideration! Ken

[luhanmcs]

try this external tool in python work fine and morely fast https://github.com/notsatan/kodi-strm

[klyco]

Interesting, I'll take a look, although I would ideally like to keep the functionality within the Google Drive addon for ease for use.

*UPDATE - Also, this code does not make use of multiple threads, correct?

Cheers, Ken

[luhanmcs]

I have 1489 tvshow with 58000+ episodes and 1400+ movies in total my library google drive, in some tests I did I don't remember the exact time, but I can guarantee that it took less than 2h30m. I manage and create my NFO of episodes/movies my content with the tineymediamanager app. And I also download the NFO with rclone to the folders so that kodi reads the information from the videos.

[0o120]

I have my own private fork of plugin.googledrive where I improved the strm export. I have 25,000 videos in the directory format of:

/videos/
/videos/video1/video1.mp4
/videos/video2/video2.mp4
/videos/video3/video3.mp4
...

Takes about 10-20 minutes to do a full export of 25,000 videos (Not including tmdb scraping). I'll see about making a pull request with it here without having to change too much. My personal fork is changed a lot to cater to my specific needs.

[klyco]

Thanks to both @luhanmcs and @0o120 for your kind offers and suggestions. Both seem great and offer me some choice.

@cguZZman - I wonder if we can merge the export improvements from @0o120 into the main code for your addon?

Cheers! Ken

[luhanmcs]

I have my own private fork of plugin.googledrive where I improved the strm export. I have 25,000 videos in the directory format of:

/videos/
/videos/video1/video1.mp4
/videos/video2/video2.mp4
/videos/video3/video3.mp4
...

Takes about 10-20 minutes to do a full export of 25,000 videos (Not including tmdb scraping). I'll see about making a pull request with it here without having to change too much. My personal fork is changed a lot to cater to my specific needs.

I made your "pull requests" changes and it was much faster to create just the .STRM But I also use .NFO and to download them it is still very slow by the addon. Would it be possible to make some modification to also speed up the download of .NFO files? Or even read the .NFO data in the same folder as the videos directly in the addon. (https://github.com/cguZZman/plugin.googledrive/issues/301)

@0o120 thank you so much

[0o120]

I made your "pull requests" changes and it was much faster to create just the .STRM But I also use .NFO and to download them it is still very slow by the addon. Would it be possible to make some modification to also speed up the download of .NFO files? Or even read the .NFO data in the same folder as the videos directly in the addon. (#301)

@0o120 thank you so much

I'm not sure I could make that part faster since it's actually downloading the .nfo file and requires it's own request to get the file. Nothing is really being downloaded when the .strm files are created, they are just being generated by the google drives file ID, so it's basically instant.

The only thing I can suggest that would make that faster is having all your NFO's in 1 zip file, then making your own fork of the clouddrive addon that downloads that zip file and unpacks it after it's downloaded. Or implement threading somewhere in the clouddrive addon which might take some work but I'm honestly not sure if that would work out okay.

That's all I can think of... Sorry.

If I get a chance, I'll look into threads and see if it's a viable solution. Then add it as an option and allow number of threads to be set, no promises though. There's issues you can run into, such as google drive API limits, depending on how many threads you have going.

If you want to look into it yourself, the .nfo download is happening here after if is_download:.

[0o120]

I made your "pull requests" changes and it was much faster to create just the .STRM But I also use .NFO and to download them it is still very slow by the addon. Would it be possible to make some modification to also speed up the download of .NFO files? Or even read the .NFO data in the same folder as the videos directly in the addon. (#301)

@0o120 thank you so much

So I got threading to work and tested it with some NFO's, but anymore than 3 threads wouldn't make a difference.

Here's my test results:

200 Movie Folders + 200 NFO's

1 Thread: 99177.37 ms
2 Threads: 70080.79 ms
3 Threads: 46354.79 ms
4 Threads: 52246.10 ms
5 Threads: 52389.81 ms
6 Threads: 53625.98 ms

3 Threads seems to be the sweet spot and shaves off about half the time it normally takes to download them all. If you're interested, I could put the code up for you, but it's experimental and requires testing on your part to make sure it works as intended. If you're downloading a ton of NFO's, you could possibly also run into some google drive API limits which could also cause issues if using threads.

[JDRIVO]

@0o120 @klyco if any of you are feeling daring, try my google drive addon and let me know how you find the STRM export performance. https://github.com/JDRIVO/gDrive

[klyco]

@JDRIVO - Yes I would be honored to test it! :-) I just need a few days as I am travelling. Once I test it, I will post my thoughts

[JDRIVO]

@klyco I admire your bravery.