search

cgutteridge / Graphite

PHP RDF Library
http://graphite.ecs.soton.ac.uk/
48 stars 14 forks source link

Test coverage for retrieving data from sameas.org #17

Closed CloCkWeRX closed 12 years ago

CloCkWeRX commented 12 years ago

Looks like I forgot to send in a pull request for this :S

More test coverage plus some minor fixes for the travis-ci config. As you can see it's the "minimal" effort to shift the retrieving code out of the core Graphite class to allow different drivers - just enough to get the tests passing; and to avoid breaking BC.

CloCkWeRX commented 12 years ago

Also, this actually comes before pull request #16

cgutteridge commented 12 years ago

should be merged in now.

Can you do a git pull to grab my changes too? specifically making ARC2 only load if it's not already loaded -- this way it doesn't force a path on people.

On 31/03/2012 13:39, Daniel O'Connor wrote:

Looks like I forgot to send in a pull request for this :S

More test coverage plus some minor fixes for the travis-ci config. As you can see it's the "minimal" effort to shift the retrieving code out of the core Graphite class to allow different drivers - just enough to get the tests passing; and to avoid breaking BC.

You can merge this Pull Request by running:

git pull https://github.com/CloCkWeRX/Graphite 35bb6b7a

Or you can view, comment on it, or merge it online at:

https://github.com/cgutteridge/Graphite/pull/17

-- Commit Summary --

  • Get travis to install ARC2
  • Point to 'stable' ARC2
  • Get phpunit coverage out in travis builds
  • Extract fetching to an alternative class
  • Fix failure where 4 triples were loaded if you had net connectivity/had a blank URI
  • Add coverage with a mocked out retreiver to fetch remote resources

-- File Changes --

M .travis.yml (3) M Graphite.php (83) M Graphite/Resource.php (4) A Graphite/Retriever.php (91) M tests/Graphite_ResourceTest.php (22) A tests/data/sameas.org.rdf (168)

-- Patch Links --

https://github.com/cgutteridge/Graphite/pull/17.patch https://github.com/cgutteridge/Graphite/pull/17.diff

Reply to this email directly or view it on GitHub: https://github.com/cgutteridge/Graphite/pull/17

Christopher Gutteridge -- http://id.ecs.soton.ac.uk/person/1248

Graphite PHP RDF Library v1.5 released! http://graphite.ecs.soton.ac.uk/ University of Southampton Open Data Service: http://data.southampton.ac.uk/ You should read the ECS Web Team blog: http://blogs.ecs.soton.ac.uk/webteam/

CloCkWeRX commented 12 years ago

Yup - I integrated 8ca56765ec663e2636f80a12dc49f9d95f3042ea

We're all in sync atm - https://github.com/cgutteridge/Graphite/network