Minor Kaleidoscope Enhancement and Current Issue

cgvirus / Olive-Editor-Community-Effects

A community effort to populate effects for Olive-Editor

60 stars 7 forks source link

Minor Kaleidoscope Enhancement and Current Issue #16

Closed ghost closed 5 years ago

ghost commented 5 years ago

Enhancements

Capitalized etting names in the .xml
Rotation is less sensitive to value changes
Removed arbitrary max values: This way a person can have a progressive kaleidoscope background without reaching a limited dead-end

Issue

Except my modified Rotation settings, the rest of the settings are really sensitive to value changes. For example, increasing a value by 1 drastically changes everything. This effects animation alot.

cgvirus commented 5 years ago

Hi instead of 100 division we should use *.01 division will make SAW wave, multiply will make SINE wave. We can give all params this multiplication as Olive uses floats when pressing ctrl+drag. Should we take this approach? What do you think? I am quite busy today. I will test the rotation tomorrow. Then will merge it. Thanks.

ghost commented 5 years ago

@cgvirus I believe giving all of the params the multiplication is a reasonable solution.

Kaleidoscope Type 2, 3, and 5 are aggressive to minor param changes, even with ctrl+drag.

cgvirus commented 5 years ago

Just merging without checking and more adjustment due to high volume work pressure. Will update it hopefully soon.