search

cgvirus / Olive-Editor-Community-Effects

A community effort to populate effects for Olive-Editor
60 stars 7 forks source link

I've made a simple despill effect for green screen #18

Closed unfa closed 5 years ago

unfa commented 5 years ago

I've coded a simple despill effect for fixing gree nedges on green screen chorma-keyed footage for my own needs.

It lacks any configuration rigth now.

I'd like to make it work for R G or B channels, and allow controlling the influence and other things, but I don't know how to do that yet.

Here's the code:

despill.tar.gz

unfa commented 5 years ago

I've tried to add an option to choose which channel will be despilled, but for some reason it stopped working.

If you can - please help me fix it.

I don't know how to debug a shader :P

despill2.tar.gz

cgvirus commented 5 years ago

It was not working as you have declared same variable r g b twice in the same scope. Here is the modification despill.zip

unfa commented 5 years ago

Yeah, thanks! Someone on Olive Disocrd also pointed this out to me.

unfa commented 5 years ago

Anyway - I've submitted a pull request to Olive master.

cgvirus commented 5 years ago

Most welcome. Closing the issue then.

unfa commented 5 years ago

Thanks! I've learned how to submit PRs for this. I'll probably make more efects in the future.

cgvirus commented 5 years ago

If the main Olive branch is busy (it is actually), you can submit your effects here in this community repo as well. I will verify and merge them ASAP. Thanks for the contrib.

unfa commented 5 years ago

I'll see, I wouldn't want to duplicate that as it'd only raise confusion.