search

cgvirus / Olive-Editor-Community-Effects

A community effort to populate effects for Olive-Editor
60 stars 7 forks source link

Fixed Denoise Alpha #8

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hello, this PR changes the following

Vec4 Alpha issues to address

This happens to all effects that use gl_FragColor.a (except for glitch and the my fixed denoise)..

  1. When screenshoting through Save Frame as Image..., frames that use an effect with gl_FragColor.a makes the screenshot transparent with no content
  2. Effects that use gl_FragColor.a composites under layers instead of overlapping layers as it should.
cgvirus commented 5 years ago

Hi please let me know some example if you can. Tested with OCIO branch seems to be fine. I am using a transparent .png at top with effects and a footage under it for testing. What is your scenario? Also tested save frame

ghost commented 5 years ago

@cgvirus

Here is the issue. The bokeh blurred video is the bottom strip. The circled video is the top strip.

Without sharpen on the top strip olive-editor_qyTepLbyDk

With sharpen on the top strip olive-editor_KscimstLvf

cgvirus commented 5 years ago

Thanks for the feedback...I have updated the file as necessary...I am closing this pull as it will conflict the files now with it https://github.com/cgvirus/Olive-Editor-Community-Effects/commit/20a28c2b91676019e0b0e442cb9828c412a2f7ac Thanks again for your hard work.