search

cgwalters / git-evtag

Extended verification for git tags
Other
129 stars 13 forks source link

Fix nested submodules #36

Closed pwithnall closed 2 years ago

pwithnall commented 5 years ago

While top-level submodules (e.g. $GIT_DIR/mysubmodule) were working fine, those in subdirectories (for example, $GIT_DIR/subprojects/mysubmodule) were not, since the middle part of the path (‘subprojects’) was being dropped during the checksum recursion.

Fixing this is especially important for any project using Meson-style subprojects, which are conventionally all grouped in the ‘subprojects’ directory.

Signed-off-by: Philip Withnall withnall@endlessm.com

pwithnall commented 3 years ago

Trivially rebased and added one tiny fix to the TAP line which lists the number of tests. I haven’t re-tested it; that can be done if anyone ever takes a look at this for review.

pwithnall commented 2 years ago

Any chance of getting this reviewed and landed? I’ve been using it for over a year without problems now, and aiui it’s not possible to release GLib without it (due to use of submodules within Meson’s subprojects/ directory).

pwithnall commented 2 years ago

/cc @cgwalters

3v1n0 commented 2 years ago

Would be quite nice to have this merged and released :)

cgwalters commented 2 years ago

Sorry, I completely missed notifications for this!

Looks good to me!

pwithnall commented 2 years ago

Thank you!